Skip to content

[WIP] 4161 - Fix TRex dataframe cleanup function#4162

Closed
4gt-104 wants to merge 1 commit intoNVIDIA:release/10.4from
4gt-104:release/10.4
Closed

[WIP] 4161 - Fix TRex dataframe cleanup function#4162
4gt-104 wants to merge 1 commit intoNVIDIA:release/10.4from
4gt-104:release/10.4

Conversation

@4gt-104
Copy link
Copy Markdown

@4gt-104 4gt-104 commented Sep 26, 2024

Fix 'clean_df' function in 'trex/df_preprocessing.py' module which misbehaves not selecting any existing columns to delete in order to cleanup dataframe for visualization.

Resolves: #4161

Fix 'clean_df' function in 'trex/df_preprocessing.py' module
which misbehaves not selecting any existing columns to delete
in order to cleanup dataframe for visualization.

Resolves: #4161
Signed-off-by: Tigran Grigoryan <grigoryan.tigran119@gmail.com>
@4gt-104
Copy link
Copy Markdown
Author

4gt-104 commented Sep 26, 2024

I am not sure to which branch the change should be merged as I have not found any information regarding experimental subprojects in CONTRIBUTING.md.

@netaz
Copy link
Copy Markdown

netaz commented Oct 6, 2024

Thanks @4gt-104! - the fix looks correct but I want to test it before merging, and it will take me a little while to get to it.
Note that TRT's backend is rapidly changing and a lot of the features offered by the TREX API will stop being useful soon, if not already.
The chief reason is that TRT performs much more aggressive fusions and the grouping and accounting of operations is not feasible. I will need to rework the API.

@4gt-104 4gt-104 closed this by deleting the head repository Mar 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TRex package contains functions that do not work as expected.

2 participants